Dolphin Git 5.0-4191

Dolphin Git 5.0-4191 is compiled. This is the trunk of Dolphin Project. Dolphin is the first Gamecube emulator able to run commercial games! Dolphin is a Gamecube, Wii and Triforce (the arcade machine based on the Gamecube) emulator which supports many extra features and abilities not present on the original consoles. It has a partial Wii support and plays most Gamecube games.

Dolphin Git changelog:
* quick UB fix for 3c0bdd74
* Merge pull request #5559 from JosJuice/discio-rename
DiscIO: Remove C/I/S prefixes from class names
* DiscIO: Remove C/I/S prefixes from class names
These prefixes were inconsistent with the rest of Dolphin.
I'm also renaming VolumeWiiCrypted to VolumeWii because of 1113b13.
* Merge pull request #5558 from Tilka/fix_warnings
Interpreter: simplify srawx/srawix
* Interpreter: simplify srawx/srawix
This also avoids -Wint-in-bool-context warnings in GCC 7.
* Merge pull request #5556 from shuffle2/jloehr-FixWiimoteReportSizeOnWindows
fix wiimote report size on windows
* windows: make IORead return number of valid bytes according to ReportID
* Merge pull request #5548 from JosJuice/volume-wii-unencrypted
Reimplement support for unencrypted Wii discs
* Reimplement support for unencrypted Wii discs
You may want to read the PR #2047 comments before reading this.
Dolphin attempts to support an unencrypted type of Wii discs
that apparently is identified by a 4-byte integer at 0x60
being non-zero. I don't know what discs (if any) would be
using that format, so I haven't been able to test Dolphin's
support for it, but it has probably been broken for a while.
The old implementation is very short but also strange.
In CreateVolumeFromFilename, we read a 4-byte integer from
0x60, and if it's non-zero, we create a CVolumeGC object
instead of a CVolumeWiiCrypted object. This might seem like
it makes no sense, but it presumably worked in the past
because IsVolumeWiiDisc used to check the volume type by
reading the magic word for Wii straight from the disc,
meaning that CVolumeGC objects representing unencrypted Wii
discs would be treated as Wii discs by pretty much all of
Dolphin's code except for the volume implementation code.
(It wasn't possible to simply use CVolumeWiiCrypted, because
that class only handled encrypted discs, like the name says.)
However, that stopped working as intended because of ace0607.
And furthermore, bb93336 made it even more broken by making
parts of Dolphin expect that data read from Wii discs needed
to be decrypted (rather than the volume implementation
implicitly deciding whether to decrypt when Read was called).
Disclaimer: Like I said before, I haven't been able to test
any of this because I don't have any discs that use this
unencrypted Wii disc format, so this is all theoretical.
Later, PR #2047 tried to remove Dolphin's support for
the unencrypted Wii disc format because seemingly no
discs used it, but the PR got closed without being merged.
At the end of that PR, I said that I would make a new PR
with a better implementation for the format after PR #2353
was merged. Now that PR #2353 is merged (two years later...)
and PR #5521 is merged, the new implementation was easy to
make, and here it is!
Untested.
* Merge pull request #5555 from JosJuice/ub-string-comparisons
Fix UB string comparisons
* Fix UB string comparisons
Also replacing auto& with const char* so that it's easier
to see that these strings aren't std::strings.
* Merge pull request #5554 from shuffle2/cmake-msvc-conformance
cmake: enable same conformance-related flags as msbuild
* cmake: enable same conformance-related flags as msbuild
* Merge pull request #5553 from sepalani/strpopback
StringUtil: Add StringPopBackIf UnitTests
* StringUtil: Add StringPopBackIf UnitTests
* Merge pull request #5199 from ligfx/default_gci_folder
Make EXIDEVICE_MEMORYCARDFOLDER the default for slot A
* Make EXIDEVICE_MEMORYCARDFOLDER the default for slot A
The average user doesn't care, and for users who mix NTSC and PAL games
it avoids the "Memory Card is formatted for another market" message. For
non-average users, it's probably fine to have save data as separate
files anyways.
Might need some interface/string changes to explain what GCI Folder is
and why it's the default?
* Merge pull request #5536 from sepalani/getstring
HLE: Prevent GetStringVA to strip newlines
* StringUtil: StringPopBackIf added
* HLE: Prevent GetStringVA to strip newlines
* Merge pull request #5418 from MerryMage/config-again-and-again
VideoConfig: Port to layered configuration system

Download: Dolphin Git 5.0-4191 x64
Download: Dolphin Git 5.0-4191 Android
Source: HereDolphin Git 5.0-2877